Fixed issue where attachments < 3mb were not being encoded correctly #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
============================================
- Coverage 80.46% 79.92% -0.54%
- Complexity 281 283 +2
============================================
Files 29 30 +1
Lines 824 842 +18
Branches 79 86 +7
============================================
+ Hits 663 673 +10
- Misses 119 120 +1
- Partials 42 49 +7 ☔ View full report in Codecov by Sentry. |
atejada
approved these changes
Apr 30, 2024
mrashed-dev
deleted the
TW-2895-kotlin-gh-222-attachments-not-send-when-3-mb
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Apr 30, 2024
# Changelog ### Added * Added missing webhook triggers (#220) * Added provider field to token exchange response (#225) * Added support for clean messages endpoint (#226, #228) * Added support for custom headers field for Drafts and Messages (#223) * Added support for overriding various fields of outgoing requests (#224) ### Changed * Fixed issue where attachments < 3mb were not being encoded correctly (#227, #222) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where we were not encoding attachments less than 3mb properly.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.