Add "from" field to CreateDraftRequest #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burtonrhodes
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
mrashed-dev
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=========================================
Coverage 80.04% 80.04%
Complexity 284 284
=========================================
Files 30 30
Lines 847 847
Branches 86 86
=========================================
Hits 678 678
Misses 120 120
Partials 49 49 ☔ View full report in Codecov by Sentry. |
mrashed-dev
approved these changes
Jun 26, 2024
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jun 26, 2024
# Changelog * Fixed default When type (#235) * Fixed issue where from field was not accessible when creating drafts (#233, #234) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK should allow setting the "from" address. This was a feature in v2 and is available in the v3 API. Many accounts have "from" aliases or valid alternate "from" addresses that can be used when sending emails.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.