Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when type for date #235

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

nickbair-nylas
Copy link
Contributor

Update When Date class to use WhenType of DATE instead of DATESPAN.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@mrashed-dev
Copy link
Contributor

@nickbair-nylas excellent, love the test as well!

@mrashed-dev mrashed-dev merged commit d173b93 into nylas:main Jun 26, 2024
1 of 2 checks passed
@mrashed-dev mrashed-dev mentioned this pull request Jun 26, 2024
mrashed-dev added a commit that referenced this pull request Jun 26, 2024
# Changelog
* Fixed default When type (#235)
* Fixed issue where from field was not accessible when creating drafts
(#233, #234)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants