Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SendMessageRequest to add From field #237

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Jun 27, 2024

Add From field to the builder

https://nylas.atlassian.net/browse/CUST-2740

Add From field to the builder
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.04%. Comparing base (bc67e7d) to head (3d7fa12).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #237   +/-   ##
=========================================
  Coverage     80.04%   80.04%           
  Complexity      284      284           
=========================================
  Files            30       30           
  Lines           847      847           
  Branches         86       86           
=========================================
  Hits            678      678           
  Misses          120      120           
  Partials         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ajay-k ajay-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atejada atejada merged commit f7c5553 into main Jun 28, 2024
2 checks passed
@mrashed-dev mrashed-dev mentioned this pull request Jun 28, 2024
mrashed-dev added a commit that referenced this pull request Jun 28, 2024
# Changelog
### Added
* Added webhook validation support (#238)

### Changed
* Fixed issue where from field was not accessible when sending messages
(#237)

# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants