Fixed issue where reminders were not being updated correctly when updating an event #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDDM
requested review from
wallacecs007,
kraju3,
pooja169usp and
krisgardiner
AaronDDM
force-pushed
the
CUST-3760-v-3-events-unable-to-update-reminders-via-java-sdk
branch
from
4a8c0eb to
450ba3e
Compare
AaronDDM
force-pushed
the
CUST-3760-v-3-events-unable-to-update-reminders-via-java-sdk
branch
from
450ba3e to
30c5d60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 316 316
=========================================
Files 35 35
Lines 967 967
Branches 88 88
=========================================
Hits 786 786
Misses 129 129
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There was a typo in the UpdateEventRequest which supplied
overrideinstead ofoverridesfor the reminders JSON object. However, this data class was also necessarily duplicated. So I got rid of it and used the pre-existing data class.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.