Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to rotate webhook secrets #597

Merged

Conversation

Zellotath
Copy link
Contributor

@Zellotath Zellotath commented Oct 30, 2024

Description

The webhooks.rotateSecret method calls the incorrect URL, so all calls using this method fail with an error. This fixes that by switching the URL to the correct one. Closes #596.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@Zellotath Zellotath changed the title Fix the ability to rotate webhook secrets. Fix the ability to rotate webhook secrets Oct 30, 2024
Copy link
Contributor

@SubashPradhan SubashPradhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix.

@SubashPradhan SubashPradhan merged commit a641a22 into nylas:main Oct 31, 2024
4 of 5 checks passed
@SubashPradhan SubashPradhan mentioned this pull request Oct 31, 2024
@Zellotath Zellotath deleted the nf/596/fix-webhook-secret-rotation branch October 31, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to rotate webhook secrets
2 participants