Fix query parameters for array values #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating a new snakeCaseKey=item for each item in the value array. This was creating multiple instances of the snakeCaseKey query param if there is more than one item in an array.
tjovicic
reviewed
Nov 20, 2024
| for (const item of value) { | ||
| url.searchParams.append(snakeCaseKey, item as string); | ||
| } | ||
| url.searchParams.append(snakeCaseKey, value.join(',')); |
There was a problem hiding this comment.
@wallacecs007 can you write a test? Also, will this apply only to the anyEmail query param or all?
There was a problem hiding this comment.
@tjovicic I fixed the test that was failing due to this change and this will apply to all query parameters. I don't see any case in our API spec docs where we would want multiple of the same query parameter passed in to Nylas outside of Metadata.
Metadata has it's own case and will be unaffected.
There was a problem hiding this comment.
@tjovicic This fix will apply to any query_params that are sent as an Array.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were creating a new snakeCaseKey=item for each item in the value array.
This was creating multiple instances of the snakeCaseKey query param if there is more than one item in an array.
If more than one value was passing more than one value in an array query parameter we were generating a URL that looks like this:
/v3/grants/9a8ce69e-61a5-42c5-bdda-1ab3c3745093/threads?limit=5&any_email=chase.w%40nylas.com&any_email=nick.b%40nylas.comThis change makes it so that the above URL instead produces the following request URL:
/v3/grants/9a8ce69e-61a5-42c5-bdda-1ab3c3745093/threads?limit=5&any_email=chase.w%40nylas.com,nick.b%40nylas.comLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.