Fix bug when deserializing delete response (#277)

For `.destroy()` method we are not using the correct model to deserialize the response to. We just discard it and use `Response` which results in a KeyError.
nylas · Sep 28, 2023 · 71af6b5 · 71af6b5
1 parent 0275b3e
commit 71af6b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ nylas-python Changelog
 v6.0.0b3
 ----------------
 * Fix bug when deserializing Union types
+* Fix bug when deserializing delete response
 
 v6.0.0b2
 ----------------

diff --git a/nylas/handler/api_resources.py b/nylas/handler/api_resources.py
@@ -69,4 +69,4 @@ def destroy(
         response_json = self._http_client._execute(
             "DELETE", path, headers, query_params, request_body
         )
-        return Response.from_dict(response_json, response_type)
+        return response_type.from_dict(response_json)
diff --git a/nylas/models/events.py b/nylas/models/events.py
@@ -316,7 +316,7 @@ class Event:
     participants: List[Participant]
     when: When = field(metadata=config(decoder=_decode_when))
     conferencing: Optional[Conferencing] = field(
-        metadata=config(decoder=_decode_conferencing)
+        default=None, metadata=config(decoder=_decode_conferencing)
     )
     object: str = "event"
     description: Optional[str] = None