Skip to content

Commit

Permalink
[77881] Add missing source field in Contact class (#187)
Browse files Browse the repository at this point in the history
This PR adds a missing field to the Contact class.
  • Loading branch information
mrashed-dev authored Jan 13, 2022
1 parent a6524b6 commit 8eafc58
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
nylas-python Changelog
======================

Unreleased
----------------
* Add missing `source` field in `Contact` class

v5.4.1
----------------
* Fix issue where keyword arguments calling `_update_resource` were not correctly resolving to URL params
Expand Down
1 change: 1 addition & 0 deletions nylas/client/restful_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ class Contact(NylasAPIObject):
"job_status_id",
"manager_name",
"office_location",
"source",
"notes",
"picture_url",
]
Expand Down
1 change: 1 addition & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,7 @@ def mock_contact(mocked_responses, account_id, api_url):
"job_title": "QA Tester",
"manager_name": "George",
"office_location": "Over the Rainbow",
"source": "inbox",
"notes": "This is a note",
"picture_url": "{base}/contacts/{id}/picture".format(
base=api_url, id="9hga75n6mdvq4zgcmhcn7hpys"
Expand Down
1 change: 1 addition & 0 deletions tests/test_contacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def test_get_contact(api_client):
assert contact.given_name == "Given"
assert contact.surname == "Sur"
assert contact.birthday == date(1964, 10, 5)
assert contact.source == "inbox"


@pytest.mark.usefixtures("mock_contacts")
Expand Down

0 comments on commit 8eafc58

Please sign in to comment.