Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where attachments < 3mb were not being encoded correctly #362

Merged

Conversation

mrashed-dev
Copy link
Contributor

Description

This PR fixes the encoding for attachments (<3mb) being sent via application/json.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@atejada atejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test it 👍 Ready to 🚀

@mrashed-dev mrashed-dev merged commit a4f3bad into main May 6, 2024
4 checks passed
@mrashed-dev mrashed-dev deleted the TW-2974-python-fix-attachments-not-sending-when-3-mb branch May 6, 2024 13:00
@mrashed-dev mrashed-dev mentioned this pull request May 17, 2024
mrashed-dev added a commit that referenced this pull request May 17, 2024
# Changelog
* Added support for custom headers field for drafts and messages (#360)
* Added support for overriding various fields of outgoing requests (#363)
* Added support for `provider` field in code exchange response (#360)
* Added support for `event_type` filtering field for listing events (#364)
* Added clean messages support (#361)
* Added additional webhook triggers (#357)
* Fixed issue where attachments < 3mb were not being encoded correctly (#362)
* Fixed issue deserializing event and code exchange responses (#358, #368, #369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants