Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scope as an optional parameter to the CodeExchangeResponse #368

Merged
merged 1 commit into from
May 17, 2024

Conversation

kraju3
Copy link
Contributor

@kraju3 kraju3 commented May 17, 2024

Description

Adding scope as an optional string due to ICloud and IMAP grants not having a scope property associated with them.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Update it to str

Remove duplicate scope value
@mrashed-dev mrashed-dev merged commit 25d7331 into nylas:main May 17, 2024
3 of 4 checks passed
@mrashed-dev mrashed-dev mentioned this pull request May 17, 2024
mrashed-dev added a commit that referenced this pull request May 17, 2024
# Changelog
* Added support for custom headers field for drafts and messages (#360)
* Added support for overriding various fields of outgoing requests (#363)
* Added support for `provider` field in code exchange response (#360)
* Added support for `event_type` filtering field for listing events (#364)
* Added clean messages support (#361)
* Added additional webhook triggers (#357)
* Fixed issue where attachments < 3mb were not being encoded correctly (#362)
* Fixed issue deserializing event and code exchange responses (#358, #368, #369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants