Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing schedule-specific fields to Message model #385

Conversation

mrashed-dev
Copy link
Contributor

Description

This PR adds in two fields, schedule_id and send_at, to the Message model. These fields are returned by the API if the message being sent is scheduled.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@kraju3 kraju3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrashed-dev mrashed-dev merged commit a53c164 into main Sep 20, 2024
4 checks passed
@mrashed-dev mrashed-dev deleted the CUST-2830-v-3-python-sdk-send-message-response-in-python-sdk-does-not-contain-schedule-id-field branch September 20, 2024 21:48
@mrashed-dev mrashed-dev mentioned this pull request Sep 24, 2024
mrashed-dev added a commit that referenced this pull request Sep 24, 2024
* Add support for from field for sending messages (#386)
* Add missing schedule-specific fields to Message model (#385)
* Add migration grant properties (#387)
* Fix from field not being optional causing deserialization errors (#382)
* Fix IMAP identifiers not encoding correctly (#383)
* Fix NylasOAuthError not setting the status code properly (#388, #379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants