Support custom attachment filename for large files #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loomchild
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
loomchild
commented
Nov 13, 2024
| file.define_singleton_method(:original_filename) { filename } if filename | ||
|
|
||
| content_type = attachment[:content_type] || attachment["content_type"] | ||
| file.define_singleton_method(:content_type) { content_type } if content_type |
There was a problem hiding this comment.
This might not be required - added as a bonus.
loomchild
commented
Nov 13, 2024
lib/nylas/utils/file_utils.rb
Outdated
| @@ -36,6 +36,13 @@ def self.build_form_request(request_body) | |||
| file = File.open(attachment[:file_path], "rb") | |||
| end | |||
|
|
|||
| # Setting original filename and content type if available. See code rest-client#lib/restclient/payload.rb | |||
There was a problem hiding this comment.
Using not fully documented rest-client feature to set the filename in the payload. See https://github.com/rest-client/rest-client/blob/master/lib/restclient/payload.rb#L185 for more info.
loomchild
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
SubashPradhan
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for attachments > 3MB.
Follow-up of #496.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.