Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove comment from READMEs #166

Merged
merged 1 commit into from
Oct 25, 2023
Merged

remove comment from READMEs #166

merged 1 commit into from
Oct 25, 2023

Conversation

gudsson
Copy link
Contributor

@gudsson gudsson commented Oct 25, 2023

Description

Removes internal comment visible in READMEs

JIRA

@gudsson gudsson requested a review from sanscontext October 25, 2023 00:34
@gudsson
Copy link
Contributor Author

gudsson commented Oct 25, 2023 •
edited
Loading

@sanscontext I'm just removing your comment since it is visible in the READMEs that get downloaded. I'd keep the build instruction since they'll want to build to optimize for production.

sanscontext
sanscontext approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't realize those were still in there.

@gudsson gudsson merged commit e1aff7a into main Oct 25, 2023
@gudsson gudsson deleted the jg/remove-comments branch October 25, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanscontext sanscontext sanscontext approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gudsson @sanscontext