Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed poetry and added pipenv #8

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Removed poetry and added pipenv #8

merged 2 commits into from
Feb 1, 2025

Conversation

rofrano
Copy link
Contributor

@rofrano rofrano commented Feb 1, 2025

Poetry was giving students a lot of problems with it's lock file, didn't play well in Dockerfiles, and the 2.0 version removed the shell command so I decided to just remove it in favor of pipenv which seems a lot easier to use.

Made the following changes:

  • Create a Pipfile and Pipfile.lock for the project
  • Move tool configurations from the pyproject.toml back to the setup.cfg file
  • Removed the pyproject.toml, poetry.toml, and poetry.lock files from the project
  • Updated the Devcontainer Dockerfile to use pipenv
  • Updated the production Dockerfile to use pipenv
  • Made some adjustments to the Makefile
  • Updated the installed dev tools to the latest versions
  • Removed Thunder Client from dev environment because it is not free anymore
  • Removed Red Hat Analytics tools from dev environment because it kept giving Java errors and this is a Python environment (no Java)
  • Updated the GitHub Action to remove poetry and use pipenv

@rofrano rofrano merged commit a59f5b4 into master Feb 1, 2025
1 check passed
@rofrano rofrano deleted the sp25-updates branch February 1, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant