Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stringify classes without ToStringHelper #520

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

abitofevrything
Copy link
Member

Description

Stringifying some classes without ToStringHelper (e.g Stream) results in async errors (e.g Stream.first) that are not caught in stringifyInstance, as well as filling up the console output.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

@abitofevrything abitofevrything added bug Something isn't working major-change labels Aug 21, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Aug 21, 2023
@abitofevrything abitofevrything self-assigned this Aug 21, 2023
@abitofevrything abitofevrything merged commit 4ad3c76 into rewrite Aug 21, 2023
7 checks passed
@abitofevrything abitofevrything deleted the bug/less-stringify branch August 21, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major-change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants