Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing command permissions error #613

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

abitofevrything
Copy link
Member

Description

Handles errors from the fetch command permissions endpoint that indicate no permission overrides were set by returning an empty list of permissions instead of errorring.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Dec 31, 2023
@abitofevrything abitofevrything added this to the 6.2.0 milestone Dec 31, 2023
@abitofevrything abitofevrything self-assigned this Dec 31, 2023
@abitofevrything abitofevrything merged commit 1a4ed82 into dev Dec 31, 2023
7 checks passed
@abitofevrything abitofevrything deleted the bug/missing-command-permissions branch December 31, 2023 14:58
abitofevrything added a commit that referenced this pull request Apr 1, 2024
* Handle missing command permissions error and return an empty array instead

* Add application commands integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants