Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for soundboard #708

Merged
merged 20 commits into from
Oct 16, 2024
Merged

add support for soundboard #708

merged 20 commits into from
Oct 16, 2024

Conversation

Rapougnac
Copy link
Member

@Rapougnac Rapougnac commented Oct 7, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Use smart commits here to manipulate issues (eg. Fixes #issue)

Connected issues & other potential problems

If changes in PR are connected to other issues or are affecting code in other parts of framework
(e.g. in main package or any other subpackage) make sure to link issue/PR and describe said problem

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Rapougnac Rapougnac self-assigned this Oct 7, 2024
@Rapougnac Rapougnac added the enhancement New feature or request label Oct 7, 2024
@Rapougnac Rapougnac added this to the 6.5.0 milestone Oct 7, 2024
Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some tests too? We might not be able to test creating/updating sounds, but at least a unit test via testManager and an integration test for listing should be possible.

lib/src/client_options.dart Outdated Show resolved Hide resolved
lib/src/utils/cache_helpers.dart Outdated Show resolved Hide resolved
lib/src/gateway/gateway.dart Show resolved Hide resolved
lib/src/builders/sentinels.dart Outdated Show resolved Hide resolved
lib/src/builders/soundboard.dart Outdated Show resolved Hide resolved
lib/src/client_options.dart Outdated Show resolved Hide resolved
@l7ssha l7ssha modified the milestones: 6.5.0, 6.6.0 Oct 10, 2024
@Rapougnac Rapougnac marked this pull request as ready for review October 10, 2024 14:32
lib/src/builders/soundboard.dart Outdated Show resolved Hide resolved
lib/src/models/gateway/events/voice.dart Outdated Show resolved Hide resolved
lib/src/utils/cache_helpers.dart Outdated Show resolved Hide resolved
@Rapougnac Rapougnac merged commit d93aa12 into dev Oct 16, 2024
4 checks passed
@Rapougnac Rapougnac deleted the feat/soundboard branch October 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants