Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignoring CommandsPlugin.guild when creating commands #145

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

abitofevrything
Copy link
Member

Description

Setting CommandsPlugin.guild had no effect when registering commands, leading to commands without guild checks being global even if a guild was specified. This PR fixes that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze .
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Nov 23, 2023
@abitofevrything abitofevrything added this to the 6.0.1 milestone Nov 23, 2023
@abitofevrything abitofevrything self-assigned this Nov 23, 2023
@abitofevrything abitofevrything merged commit e243202 into dev Nov 23, 2023
@abitofevrything abitofevrything deleted the bug/guild-commands branch November 23, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants