Arrabbiata: coining alpha challenge + implement generic coin_challenge #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/coin-alpha-challenge
branch
from
f38cebe to
c29c506
Compare
dannywillems
force-pushed
the
dw/coin-alpha-challenge
branch
from
c29c506 to
d19d3c2
Compare
dannywillems
commented
Feb 12, 2025
| }); | ||
| let verifier_answer = E1::squeeze_challenge(&mut sponge).to_biguint().into(); | ||
| self.challenges[chal] = verifier_answer; | ||
| sponge.sponge.poseidon_block_cipher(); |
There was a problem hiding this comment.
I want to abstract it later.
dannywillems
commented
Feb 12, 2025
| }); | ||
| let verifier_answer = E2::squeeze_challenge(&mut sponge).to_biguint().into(); | ||
| self.challenges[chal] = verifier_answer; | ||
| sponge.sponge.poseidon_block_cipher(); |
There was a problem hiding this comment.
I want to abstract it later.
| }); | ||
| let verifier_answer = E1::squeeze_challenge(&mut sponge).to_biguint().into(); | ||
| self.challenges[chal] = verifier_answer; | ||
| sponge.sponge.poseidon_block_cipher(); |
There was a problem hiding this comment.
why do we need to add a pass of block_cipher there ?
| }); | ||
| let verifier_answer = E2::squeeze_challenge(&mut sponge).to_biguint().into(); | ||
| self.challenges[chal] = verifier_answer; | ||
| sponge.sponge.poseidon_block_cipher(); |
There was a problem hiding this comment.
same comment as line 1272
Comment on lines
+1291
to
+1298
| let state: Vec<BigInt> = sponge | ||
| .sponge | ||
| .state | ||
| .iter() | ||
| .map(|x| x.to_biguint().into()) | ||
| .collect(); | ||
| self.prover_sponge_state = state.try_into().unwrap(); | ||
| } |
There was a problem hiding this comment.
this can be factorised with the other half of the commit
marcbeunardeau88
approved these changes
Feb 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arrabbiata/squeeze-challenge-method #3027 +/- ##
======================================================================
Coverage ? 76.86%
======================================================================
Files ? 263
Lines ? 62244
Branches ? 0
======================================================================
Hits ? 47846
Misses ? 14398
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.