Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add odin support #1064

Merged
merged 7 commits into from
Jul 28, 2023
Merged

add odin support #1064

merged 7 commits into from
Jul 28, 2023

Conversation

spsandwichman
Copy link
Contributor

#490
Adds support for Odin

original logo:
emblem-260

adapted to ascii:

                 @@@@
         @@@@@@@@@@@@    @@@@
      @@@@@@    @@@@    @@@@@@@@
   @@@@@      @@@@    @@@@    @@@@
  @@@@       @@@@    @@@@       @@@@
 @@@       @@@@@   @@@@          @@@@
@@@       @@@@    @@@@            @@@@
@@@      @@@@   @@@@               @@@
@@@    @@@@    @@@@                @@@
@@@   @@@@   @@@@                  @@@
@@@@@@@@    @@@@                  @@@@
 @@@@@@   @@@@@                  @@@@
   @@    @@@@                  @@@@
        @@@@                @@@@@
       @@@@@@@@@      @@@@@@@@
            @@@@@@@@@@@@@@@

preview:
output

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Approving, but you might want to consider styling this a bit. For example, since the original logo's background has a gradient, you might want to use true color (hex) to add a gradient to the ascii art.

@spsandwichman
Copy link
Contributor Author

awesome, I'll experiment with it when I can!

@spsandwichman
Copy link
Contributor Author

spsandwichman commented Jun 2, 2023

updated with colors
image

languages.yaml Outdated
- "#189CFF"
- "#107BCC"
chip: "#60AFFE"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

languages.yaml Outdated
Comment on lines 1642 to 1670
Odin:
type: programming
ascii: |
{0} @@@@
{0} @@@@@@@{1}@@@@@ @@@@
{0} @@@@@@ {1}@@@@ @@@@@@@{2}@
{0} @@@@@ {1}@@@@ @@@@ {2} @@@@
{0} @@@@ {1}@@@@ @@@@ {2} @@@@
{0} @@@ {1}@@@@@ @@@@ {2} @@@@
{0}@@@ {1}@@@@ @@@@ {2} @@@@
{0}@@@ {1}@@@@ @@@@ {2} @@@
{0}@@@ {1}@@@@ @@@@ {2} @@@
{0}@@@ {1}@@@@ @@@@ {2} @@@
{0}@@@{1}@@@@@ @@@@ {2} @@@@
{1} @@@@@@ @@@@@ {2} @@@@
{1} @@ @@@@ {2} @@@@
{1} @@@@ {2} @@@@@
{1} @@@@@@@{2}@@ @@@@@@@@
{1} @{2}@@@@@@@@@@@@@@
colors:
ansi:
- blue
- blue
- blue
hex:
- "#64B9FA"
- "#189CFF"
- "#107BCC"
chip: "#60AFFE"
Copy link
Owner

@o2sh o2sh Jun 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first design @spsandwichman! I took some time to clean up your ASCII art to make it more symmetrical and I also added a background:

image

I'd suggest you follow @spenserblack's suggestion and apply the gradient to the background

Odin:
  type: programming
  ascii: |
    {0}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
    {0}@@@@@@@@@@@@@@@{1}@@@@@@@@@{0}@@@@@@@@@@@@@@@@
    {0}@@@@@@@@@@@{1}@@@@{0}@@@@@{1}@@@{0}@@@{1}@@@@{0}@@@@@@@@@@
    {0}@@@@@@@@{1}@@@{0}@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@{1}@@@{0}@@@@@@@@
    {0}@@@@@@{1}@@@{0}@@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@{1}@@@{0}@@@@@@
    {0}@@@@{1}@@@{0}@@@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@{1}@@@{0}@@@@
    {0}@@@{1}@@@{0}@@@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@{1}@@@{0}@@@
    {0}@@{1}@@@{0}@@@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@{1}@@@{0}@@
    {0}@@{1}@@@{0}@@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@{1}@@@{0}@@
    {0}@@{1}@@@{0}@@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@{1}@@@{0}@@
    {0}@@{1}@@@{0}@@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@@{1}@@@{0}@@
    {0}@@{1}@@@{0}@@@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@@@{1}@@@{0}@@
    {0}@@@{1}@@@{0}@@@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@@@{1}@@@{0}@@@
    {0}@@@@{1}@@@{0}@@{1}@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@@@{1}@@@{0}@@@@
    {0}@@@@@@{1}@@@@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@@{1}@@@{0}@@@@@@
    {0}@@@@@@@@{1}@@{0}@@@{1}@@@{0}@@@@@@@@@@@@@{1}@@@{0}@@@@@@@@
    {0}@@@@@@@@@@@@{1}@@@{0}@@@@@@@@@@{1}@@@@{0}@@@@@@@@@@@
    {0}@@@@@@@@@@@@@@@{1}@@@@@@@@@@{0}@@@@@@@@@@@@@@@
    {0}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
  colors:
    ansi:
      - blue
      - white
    hex:
      - "#3882D2"
      - "#FFFFFF"
    chip: "#60AFFE"

Copy link
Owner

@o2sh o2sh Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a second revision:

image

If you're up for it, @spsandwichman, incorporating the gradient into the background could be quite a challenge. It's your call!

Odin:
  type: programming
  ascii: |
    {0}oooooooooooooooooooooooooooooooooooo
    {0}oooooooooooooooooooooooooooooooooooo
    {0}ooooooooooooo{1}@@@@@@@@@{0}oooooooooooooo
    {0}ooooooooo{1}@@@@{0}ooooo{1}@@@{0}ooo{1}@@@{0}ooooooooo
    {0}ooooooo{1}@@@@{0}oooooo{1}@@@{0}ooo{1}@@@@@@{0}ooooooo
    {0}ooooo{1}@@@@{0}ooooooo{1}@@@{0}ooo{1}@@@{0}oo{1}@@@@{0}ooooo
    {0}oooo{1}@@@{0}oooooooo{1}@@@{0}ooo{1}@@@{0}ooooo{1}@@@{0}oooo
    {0}ooo{1}@@@{0}oooooooo{1}@@@{0}ooo{1}@@@{0}ooooooo{1}@@@{0}ooo
    {0}ooo{1}@@@{0}ooooooo{1}@@@{0}ooo{1}@@@{0}oooooooo{1}@@@{0}ooo
    {0}ooo{1}@@@{0}oooooo{1}@@@{0}ooo{1}@@@{0}ooooooooo{1}@@@{0}ooo
    {0}ooo{1}@@@{0}ooooo{1}@@@{0}ooo{1}@@@{0}oooooooooo{1}@@@{0}ooo
    {0}ooo{1}@@@{0}oooo{1}@@@{0}ooo{1}@@@{0}ooooooooooo{1}@@@{0}ooo
    {0}oooo{1}@@@{0}oo{1}@@@{0}ooo{1}@@@{0}ooooooooooo{1}@@@{0}oooo
    {0}ooooo{1}@@@@@@{0}ooo{1}@@@{0}oooooooooo{1}@@@@{0}ooooo
    {0}ooooooo{1}@@@{0}ooo{1}@@@{0}ooooooooo{1}@@@@{0}ooooooo
    {0}oooooooooooo{1}@@@{0}oooooooo{1}@@@@{0}ooooooooo
    {0}ooooooooooooo{1}@@@@@@@@@@{0}ooooooooooooo
    {0}oooooooooooooooooooooooooooooooooooo
    {0}oooooooooooooooooooooooooooooooooooo
  colors:
    ansi:
      - blue
      - white
    hex:
      - "#3882D2"
      - "#FFFFFF"
    chip: "#60AFFE"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind if i removed the background and implemented a blue gradient with the O itself? I personally like the no-background look, but it's totally your call, and thank you!

Copy link
Owner

@o2sh o2sh Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course go ahead 👍 Just make sure to use the second revision as a base to extract the logo and do what you said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants