-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fortran legacy #519
Conversation
Apologies, o2sh, you may have to do the formatting, as due to an issue with the editor I am using (i think) I cannot actually get the rustfmt check to pass. |
🤔 I don't think I've seen those errors before. Looks like it's trying to enforce tab indentation over space indentation. In which case your editor is actually behaving correctly AFAIK, according to EditorConfig. Line 5 in f34303b
AFAIK the preferred Rust format is to use 4 spaces for indentation, but perhaps a different indentation style is preferred in macro calls? Are you able to update The issue you're having does bring up another issue though: ideally, it should be the diff that has its format checked, not the whole file (kind of like what lint-staged does for npm modules). |
I think i've found the problem: apon pasting part of the diff into [https://www.soscisurvey.de/tools/view-chars.php](a tool that shows non printable chars), it has become apparent that the rest of the macro is indeed formatted with tabs. I will attempt some copy pasting to fix. |
Of course, ideally I would run rustfmt locally to understand why it's showing this behavure of tabs over spaces, but unfortunately I am not able to do that right now. Might be able to try in a few hours when I have access to rustfmt. |
Ah, passes now. Copy paste saves the day. |
for anyone viewing this PR, i've made a discussion post to try and narrow down whats causing issues with rustfmt: o2sh/onefetch/discussions/521 |
Sounds good to me. |
Using F77 version of the F90 logo, as f77 is the most used "legacy" version of fortran
#490