Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coldfusion and ColdfusionScript support #971

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

theemanofsteele
Copy link
Contributor

@theemanofsteele theemanofsteele commented Feb 28, 2023

Adds support for ColdFusion.
In Linguist and Tokei, they have "ColdFusion" and "ColdFusionScript" that collectively cover all ColdFusion files.
Figured same ASCII art for both is ok. Open to suggestions and feedback though!

Supports this issue: #490

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

While I'm personally OK with this, we often try to challenge our contributors to come up with something a bit unique.

A couple of ideas to play around with:

  1. A gradient for truecolor (hex).
  2. Instead of negative space, a colored background. Maybe a dark blue background, and black for ansi.

Also, I'm unfamiliar with ColdFusion/ColdFusionScript, so I don't know how valid this is, but maybe CFS's logo could be different, unless they truly are the same language.

Comment on lines +294 to +318
ColdFusion:
type: programming
ascii: |
{0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
{0}Cf Cf
{0}Cf Cf
{0}Cf CfCfCfCf Cf
{0}Cf CfCfCfCfCf CfCfCfCfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCfCfCfCfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf Cf
{0}Cf Cf
{0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
colors:
ansi:
- Cyan
hex:
- "#DFF0FD"
chip: "#ed2cd6"
Copy link
Owner

@o2sh o2sh Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your design, here is a suggestion taking into consideration some of @spenserblack's remarks while trying to get closer to the original logo:

image

@theemanofsteele what do you think?

ColdFusion:
  type: programming
  ascii: |
    {0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
    {0}Cf{1}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@@@@@@@@@@@@@@@@@@@{0}CfCfCfCf{1}@@{0}Cf
    {0}Cf{1}@@@@@{0}CfCfCfCfCf{1}@@@@{0}CfCfCfCfCf{1}@@@{0}Cf
    {0}Cf{1}@@@@{0}CfCfCfCfCf{1}@@@@{0}CfCf{1}@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@{0}CfCf{1}@@@@@@@@@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@{0}CfCf{1}@@@@@@@@{0}CfCfCfCfCfCf{1}@@@@@@{0}Cf
    {0}Cf{1}@@{0}CfCf{1}@@@@@@@@@@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@{0}CfCf{1}@@@@@@@@@@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@{0}CfCf{1}@@@@@@@@@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@{0}CfCfCfCfCf{1}@@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@@{0}CfCfCfCfCf{1}@@{0}CfCf{1}@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@{0}Cf
    {0}Cf{1}@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@{0}Cf
    {0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
  colors:
    ansi:
      - white
      - blue
    hex:
      - "#E5F3FC"
      - "#274550"
    chip: "#ed2cd6"

Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean design @theemanofsteele, thanks a lot for your contribution.

I left a suggestion, feel free to tell me what you think 👍

Comment on lines +319 to +343
ColdFusionScript:
type: programming
ascii: |
{0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
{0}Cf Cf
{0}Cf Cf
{0}Cf CfCfCfCf Cf
{0}Cf CfCfCfCfCf CfCfCfCfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCfCfCfCfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCf CfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf CfCfCfCfCf CfCf Cf
{0}Cf Cf
{0}Cf Cf
{0}CfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCfCf
colors:
ansi:
- Cyan
hex:
- "#DFF0FD"
chip: "#ed2cd6"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @spenserblack's suggestion that you could try creating a spin-off of the original logo (similar to what was done with Fortran) for your submission. However, if you're not feeling inspired at the moment, it's perfectly fine to submit only one entry for Coldfusion and leave the logo variation for another time.

@o2sh o2sh merged commit 69738b1 into o2sh:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants