Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust all project template to impactfull change: #803

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

michalpelka
Copy link
Contributor

What does this PR do?

Fix shared compilation errors with the newest development.

The change in o3de, that requires this adjusment is described here :o3de/o3de#18498

How was this PR tested?

TBD

o3de/o3de#18498

By adding necessary lines to scene.srgi and view.srgi

Signed-off-by: Michał Pełka <[email protected]>
@byrcolin byrcolin added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 3, 2024
@jhanca-robotecai
Copy link
Contributor

@michalpelka
is this change still needed? I believe there were some changes in O3DE following PR mentioned earlier to endure the compatibility with the old projects: o3de/o3de#18566

I tested the most recent development branches:
o3de: 8fa4627037
o3de-extras: 43e688f
ROS2ProjectTemplates works correctly without your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants