Skip to content

fixed code smells

fixed code smells #658

Status Failure
Total duration 9m 38s
Artifacts

push.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 1 warning
build12 / build: tests/test_requests/test_timeline.py#L63
test_timeline AssertionError: assert dict_items([('id', '09b4e554-b867-42ed-a839-07633906e385'), ('created', 'Jan 20, 2025, 7:25:41\u202fAM'), ('updated', .../records?q=parent.access.owned_by.user:1'}}), ('permissions', {}), ('payload', {'content': 'test', 'format': 'html'})]) >= dict_items([('created_by', {'reference': {'user': '1'}, 'type': 'user', 'label': 'id: 1', 'links': {'avatar': 'https:/...lf': 'https://127.0.0.1:5000/api/users/1'}}), ('permissions', {}), ('payload', {'content': 'test', 'format': 'html'})]) + where dict_items([('id', '09b4e554-b867-42ed-a839-07633906e385'), ('created', 'Jan 20, 2025, 7:25:41\u202fAM'), ('updated', .../records?q=parent.access.owned_by.user:1'}}), ('permissions', {}), ('payload', {'content': 'test', 'format': 'html'})]) = <built-in method items of dict object at 0x7efcb91f4fc0>() + where <built-in method items of dict object at 0x7efcb91f4fc0> = {'created': 'Jan 20, 2025, 7:25:41\u202fAM', 'created_by': {'label': 'id: 1', 'links': {'avatar': 'https://127.0.0.1:5...users/1'}, 'reference': {'user': '1'}, 'type': 'user'}, 'id': '09b4e554-b867-42ed-a839-07633906e385', 'links': {}, ...}.items + and dict_items([('created_by', {'reference': {'user': '1'}, 'type': 'user', 'label': 'id: 1', 'links': {'avatar': 'https:/...lf': 'https://127.0.0.1:5000/api/users/1'}}), ('permissions', {}), ('payload', {'content': 'test', 'format': 'html'})]) = <built-in method items of dict object at 0x7efcb91eea00>() + where <built-in method items of dict object at 0x7efcb91eea00> = {'created_by': {'label': 'id: 1', 'links': {'avatar': 'https://127.0.0.1:5000/api/users/1/avatar.svg', 'records_html':.../1'}, 'reference': {'user': '1'}, 'type': 'user'}, 'payload': {'content': 'test', 'format': 'html'}, 'permissions': {}}.items
build12 / build: tests/test_requests/test_ui_serialialization.py#L117
test_user_serialization AssertionError: assert {'label': 'id...type': 'user'} == {'label': 'id...type': 'user'} Omitting 3 identical items, use -vv to show Differing items: {'links': {'avatar': 'https://127.0.0.1:5000/api/users/1/avatar.svg', 'records_html': 'https://127.0.0.1:5000/search/records?q=parent.access.owned_by.user:1', 'self': 'https://127.0.0.1:5000/api/users/1'}} != {'links': {'avatar': 'https://127.0.0.1:5000/api/users/1/avatar.svg', 'records_html': 'https://127.0.0.1:5000/search/records?q=user:1', 'self': 'https://127.0.0.1:5000/api/users/1'}} Full diff: { 'label': 'id: 1', 'links': {'avatar': 'https://127.0.0.1:5000/api/users/1/avatar.svg', - 'records_html': 'https://127.0.0.1:5000/search/records?q=user:1', + 'records_html': 'https://127.0.0.1:5000/search/records?q=parent.access.owned_by.user:1', ? +++++++++++++++++++++++ 'self': 'https://127.0.0.1:5000/api/users/1'}, 'reference': {'user': '1'}, 'type': 'user', }
build12 / build
Process completed with exit code 1.
build12 / build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636