fix: publish draft request created even if there are no files on the …

…record

oarepo_requests/types/publish_draft.py

@@ -12,7 +12,6 @@
 from typing import TYPE_CHECKING, Any
 
 import marshmallow as ma
-from invenio_access.permissions import system_identity
 from invenio_records_resources.services.uow import RecordCommitOp, UnitOfWork
 from invenio_requests.proxies import current_requests_service
 from oarepo_runtime.datastreams.utils import get_record_service_for_record
@@ -97,7 +96,24 @@ def can_create(
             raise ValueError("Trying to create publish request on published record")
         super().can_create(identity, data, receiver, topic, creator, *args, **kwargs)
         topic_service = get_record_service_for_record(topic)
-        topic_service.validate_draft(system_identity, topic["id"])
+        topic_service.validate_draft(identity, topic["id"])
+
+        can_toggle_files = topic_service.check_permission(
+            identity, "manage_files", record=topic
+        )
+
+        draft_files = topic.files   # type: ignore
+
+        if draft_files.enabled and not draft_files.items():
+            if can_toggle_files:
+                my_message = _(
+                    "Missing uploaded files. To disable files for this record please mark it as metadata-only."
+                )
+            else:
+                my_message = _("Missing uploaded files.")
+
+            raise ma.ValidationError({"files.enabled": [my_message]})
+
 
     @classmethod
     def is_applicable_to(

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = oarepo-requests
-version = 2.3.2
+version = 2.3.3
 description =
 authors = Ronald Krist <[email protected]>
 readme = README.md