Comment input length #106
Merged
Comment input length #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirekys
reviewed
Jan 7, 2025
.../ui/theme/assets/semantic-ui/js/oarepo_requests_ui/common/components/RequestCommentInput.jsx
Outdated
Show resolved
Hide resolved
mirekys
requested changes
Jan 17, 2025
.../ui/theme/assets/semantic-ui/js/oarepo_requests_ui/common/components/RequestCommentInput.jsx
Show resolved
Hide resolved
.../ui/theme/assets/semantic-ui/js/oarepo_requests_ui/common/components/RequestCommentInput.jsx
Show resolved
Hide resolved
.../ui/theme/assets/semantic-ui/js/oarepo_requests_ui/common/components/RequestCommentInput.jsx
Show resolved
Hide resolved
mirekys
approved these changes
Jan 30, 2025
|
Waiting for https://github.com/oarepo/oarepo-requests/pull/107/files merge to fix the tests |
|
mirekys
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented maximum input length + made a refactor of a few items. Namely how the confirmation modal UI props were being kept in state, the whole thing worked kind of funky and it was kind of lucky that submitting comment together with performing some action worked.