Krist/be 443 configure notifications #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 5, 2024 15:28
…e-notifications # Conflicts: # tests/conftest.py
…-443-configure-notifications
…/be-443-configure-notifications
…e-notifications # Conflicts: # tests/conftest.py
added 14 commits
January 14, 2025 14:14
…ions' into krist/be-443-configure-notifications # Conflicts: # tests/conftest.py
…r-services' into krist/be-443-configure-notifications # Conflicts: # tests/conftest.py
added 7 commits
January 27, 2025 14:50
added 2 commits
January 28, 2025 14:26
mesemus
requested changes
Jan 29, 2025
| app.config["NOTIFICATION_RECIPIENTS_RESOLVERS"] = always_merger.merge( | ||
| app_registered_event_types, config.NOTIFICATION_RECIPIENTS_RESOLVERS | ||
| ) | ||
|
|
There was a problem hiding this comment.
probably the alwaysmerge is not a correct solution - should replace a value only if it is not already there, not always
|
|
||
|
|
||
| class SpecificEntityRecipient(RecipientGenerator): | ||
|
|
| class UserEmailRecipient(SpecificEntityRecipient): | ||
| """User email recipient generator for a notification.""" | ||
|
|
||
| def __call__(self, notification: Notification, recipients: dict): |
There was a problem hiding this comment.
I'd change the methods place:
- Put call into SpecificEntityRecipient - will call the _resolve_entity method and then call self._get_recipients(entity) -> Iterator[Recipient]
- Subclasses would implement the abstract _get_recipients
There was a problem hiding this comment.
so in this case, the impl would be:
def _get_recipients(self, entity: User):
return Recipient(data={"email": entity.email})
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.