Fix/aut 3982 custom label not showing #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
Karol-Stelmaczonek
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 0 feature, 10 fixes |
tikhanovichA
approved these changes
Nov 22, 2024
bartlomiejmarszal
added a commit
that referenced
this pull request
Nov 22, 2024
fix: metadata import export bug * fix: match all properties for item & test * fix: make sure range exist for property. If not do not import value * fix: include existing property value removal only if resource contain property value * fix: finish comment * fix: Readonly Widget property ommited, secure missing range properties * fix: remove exception * fix: testInject * fix: fix line length * fix: phpcbf fix * fix: make sure getWidget not return null --------- Co-authored-by: Karol Stelmaczonek <[email protected]>
bartlomiejmarszal
added a commit
that referenced
this pull request
Nov 22, 2024
fix: metadata import export bug * fix: match all properties for item & test * fix: make sure range exist for property. If not do not import value * fix: include existing property value removal only if resource contain property value * fix: finish comment * fix: Readonly Widget property ommited, secure missing range properties * fix: remove exception * fix: testInject * fix: fix line length * fix: phpcbf fix * fix: make sure getWidget not return null --------- Co-authored-by: Karol Stelmaczonek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore properties without range
Default properties can be applied both for tests and items