-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guest user lti1p3 lang detection #365
Conversation
6dabce1
to
8319934
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #365 +/- ##
=============================================
- Coverage 31.62% 31.00% -0.62%
- Complexity 803 914 +111
=============================================
Files 102 106 +4
Lines 2726 3151 +425
=============================================
+ Hits 862 977 +115
- Misses 1864 2174 +310 ☔ View full report in Codecov by Sentry. |
8319934
to
dd53a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. This does work quite well, but not exactly what I had in mind.
I believe the change should be done on the generis-user itself.
oat-sa/generis#1037 can be another way to solve this problem.
@wazelin I just moved in 0 breaking change direction |
Fair enough. You being away next week shouldn't be a blocker for us. I'll discuss this with @augustas. Thank you for this solution! |
closed in favor of oat-sa/generis#1037 |
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Reviving the PR with a dependency on oat-sa/generis#1106. Your 0-breaking-change approach was the way to go after all, @poyuki. More info under https://oat-sa.atlassian.net/browse/INF-258 |
REL-1101
Summary
This PR aim to provide lang detection for guest user and usage of
DEFAULT_ANONYMOUS_INTERFACE_LANG
.I have some doubts about this solution. From my point of view, it's a bit crutchy, but at the moment I couldn't find anything more suitable.
Demo
https://oat-sa.atlassian.net/browse/REL-1101?focusedCommentId=225078
How to test
DEFAULT_ANONYMOUS_INTERFACE_LANG