Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adf 1579/lodash remove #484

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

taopkorczak
Copy link
Contributor

Related: https://oat-sa.atlassian.net/browse/ADF-1579

Remove lodash usage if possible.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e54fca) 14.24% compared to head (bb48dd8) 14.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #484   +/-   ##
==========================================
  Coverage      14.24%   14.24%           
  Complexity       741      741           
==========================================
  Files             40       40           
  Lines           2555     2555           
==========================================
  Hits             364      364           
  Misses          2191     2191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taopkorczak taopkorczak requested a review from oatymart November 8, 2023 09:19
Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.
Could you also merge develop to your branch, it will make those SonarQube files go away.

Copy link

github-actions bot commented Jan 4, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
18 18 0 0

Copy link

github-actions bot commented Feb 1, 2024

Version

Target Version 12.3.0
Last version 12.2.2

There are 0 BREAKING CHANGE, 1 feature, 2 fixes

@wazelin wazelin merged commit 0f75151 into develop Feb 1, 2024
5 of 6 checks passed
@wazelin wazelin deleted the feature/ADF-1579/lodash-remove branch February 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants