Feature/tdr 22/declarative funcacl #2510
Conversation
models/classes/accessControl/func/implementation/SimpleAccess.php.orig
Outdated
Show resolved
Hide resolved
models/classes/accessControl/func/implementation/ControllerAccessRight.php
Outdated
Show resolved
Hide resolved
|
Please fix phpdocs of classes and methods and declare strict types in new classes. |
scripts/update/Updater.php
Outdated
| @@ -1343,6 +1343,6 @@ public function update($initialVersion) | |||
| $this->setVersion('42.0.4'); | |||
| } | |||
|
|
|||
| $this->skip('42.0.4', '42.8.0'); | |||
| $this->skip('42.0.4', '42.9.0'); | |||
There was a problem hiding this comment.
Don't you want to set CacheOnly implementation for existing instances?
There was a problem hiding this comment.
I wanted to keep existing deployments unchanged and keep using funcAcl.
|
|
|
While not strictly required (because when installing funcAcl we replace the default implementation with the author-able one) I like the idea of splitting the interfaces. I will adapt |
Provide a new default implementation for the func ACL that does not require a persistence and that is generating the access rights based on the manifest declarations.
requires oat-sa/generis#791