Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/aut 4109/metadata resource endpoint #4212

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

bartlomiejmarszal
Copy link
Contributor

@bartlomiejmarszal bartlomiejmarszal commented Feb 25, 2025

PR Description

New Features

  • Resource Metadata Endpoint: Introduced a new endpoint to fetch resource metadata values. This endpoint allows retrieval of metadata values based on resource and metadata URIs, enhancing the ability to manage and access resource metadata efficiently.
  • Property Restriction Configuration: Implemented a mechanism to configure restricted properties based on values defined by other properties. This feature allows for dynamic property visibility and management, ensuring that certain properties can be hidden or shown based on the values of other properties.

Technical Changes

  • Resource Metadata Service: Added ResourceMetadataService to handle the retrieval of metadata values, ensuring that resources and properties exist before attempting to fetch values.
  • Property Restriction Guard: Introduced PropertyRestrictionGuard to manage property restrictions. This class checks if a property should be restricted based on predefined conditions and values. Example of use can be found in Feat/aut 4109/restricted properties extension-tao-mediamanager#527
  • Service Providers: Updated service providers to include the new ResourceMetadataService and PropertyRestrictionGuard, ensuring they are available for dependency injection.
  • Access Control: Updated access rules to grant the BACK_OFFICE role access to the ResourceMetadata module, ensuring appropriate permissions are in place for managing resource metadata.

Testing

  • Unit Tests: Added unit tests for PropertyRestrictionGuard to verify the correct behavior of property restriction logic, ensuring that properties are correctly restricted or allowed based on the defined conditions.

This update enhances the flexibility and control over resource metadata management and property visibility, providing a more robust and dynamic system for handling resource properties.

@bartlomiejmarszal bartlomiejmarszal requested review from a team, tikhanovichA, KirylHatalski, pnal, Karol-Stelmaczonek and viktar-dzmitryieu-tao and removed request for a team February 25, 2025 15:12
Copy link

github-actions bot commented Feb 25, 2025

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
241 241 0 0

Copy link

Version

Target Version 54.33.0
Last version 54.32.1

There are 0 BREAKING CHANGE, 5 features, 1 fix

Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants