-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Enrich serviceMonitor properties #170
Conversation
Signed-off-by: Jan-Otto Kröpke <[email protected]>
ca3039a
to
ab753b4
Compare
@jkroepke, could you please add the ArtifactHub annotation here? There are some missing default values here: Specifically:
And an unused one, So please fix your PR. |
Documentation should also be updated with the changes. I apologize for the fragmented review. |
I hope I hit all your points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I hit all your points
Unfortunately not yet.
After #171, please review. |
Required for custom relabeling actions or istio deployments.