feat: add possibility to route requests to sidecar container #270
Conversation
|
@pierluigilenoci since you are the most active committer of this repo, may we kindly ask you if you could please take a look? Although quite simple, this fix would be very beneficial for us 🙂 thank you so much in advance! |
|
@edorizzardi Please update the message for ArtifactHub and rebase the PR from the main branch. 🙏🏻 👍🏻 |
|
@pierluigilenoci thank you. Done |
|
@edorizzardi The chart bump is now missing (this is a new feature, so it must be a "minor"). ➕ |
|
@pierluigilenoci Updated minor version. Plus I added the parameter in the list, and added a small paragraph on how to use my changes. |
| @@ -1,5 +1,5 @@ | |||
| name: oauth2-proxy | |||
| version: 7.8.3 | |||
| version: 7.9.3 | |||
| @@ -196,6 +196,7 @@ The following table lists the configurable parameters of the oauth2-proxy chart | |||
| | `service.loadBalancerIP` | ip of load balancer | `nil` | | |||
| | `service.loadBalancerSourceRanges` | allowed source ranges in load balancer | `nil` | | |||
| | `service.nodePort` | external port number for the service when service.type is `NodePort` | `nil` | | |||
| | `service.targetPort` | name for the service's `targetPort` | `""` | |||
There was a problem hiding this comment.
"A numeric port number (e.g., 80) or a port name defined in the pod's container(s) (e.g., http)."
| @@ -357,3 +358,6 @@ config: | |||
| whitelist_domains = [ ".domain.com", ".example.io"] | |||
| provider = "google" | |||
| ``` | |||
|
|
|||
| ## Route requests to sidecar container | |||
| You can route requests to a sidecar container first by setting the `service.targetPort` variable; by default, the service's `targetPort` value equals to the `httpSchema`'s. | |||
There was a problem hiding this comment.
The possible values for the targetPort field of a Kubernetes Service can be either a port number or the name of a port defined in the pod.
| @@ -153,6 +153,9 @@ service: | |||
| externalTrafficPolicy: "" | |||
| # configure internalTrafficPolicy | |||
| internalTrafficPolicy: "" | |||
| # configure service target port | |||
| # useful when there's need to route requests to sidecar containers first | |||
There was a problem hiding this comment.
I would remove this comment.
Description
This PR changes the
Servicesuch that it allows to route requests to an arbitrary port. This is not a breaking change.