Apply suggestions from code review

obi1kenobi · Dec 8, 2024 · 7255ed4 · 7255ed4
1 parent 04a257b
commit 7255ed4
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/lints/macro_no_longer_exported.ron b/src/lints/macro_no_longer_exported.ron
@@ -23,7 +23,7 @@ SemverQuery(
                         # Check the macro still exists but is no longer public API
                         # and isn't doc(hidden) (which would be caught by another lint)
                         public_api_eligible @filter(op: "=", value: ["$false"])
-                        doc_hidden @filter(op: "=", value: ["$false"])
+                        doc_hidden @filter(op: "!=", value: ["$true"])
 
                         span_: span @optional {
                             filename @output
@@ -36,9 +36,8 @@ SemverQuery(
     }"#,
     arguments: {
         "true": true,
-        "false": false,
     },
-    error_message: "A macro that was previously exported is no longer exported. This breaks downstream code that used the macro.",
+    error_message: "A macro that was previously exported with #[macro_export] is no longer exported. This breaks downstream code that used the macro.",
     per_result_error_template: Some("macro {{name}} in {{span_filename}}:{{span_begin_line}}"),
     witness: Some((
         hint_template: r#"{{name}}!(...);"#,