Add custom registry support #1048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `--registry` command line flag to the check release capabilities. The argument to the flag is the name of the registry to use to lookup the crates when using the default behavior or --baseline-version. If left unset, the default behavior remains of --checking crates.io.
- An ephemeral axum http server is started, which serves a static file based Cargo registry (using margo) called custom-registry. - The registry custom-registry is pre-populated with the test_crates/custom_registry/old crate (version 0.1.0). - The test runs semver-checks on test_crates/custom_registry/new (version 0.1.1) against registry custom-registry and asserts that there are no SemVer violations. - After the test the axum server is shutdown gracefully on both success and failure, there is also a timeout ensure the test does not hang.
fujiapple852
commented
Dec 16, 2024
Comment on lines
+56
to
+57
| // Unclear what we should do here, panic for now... | ||
| todo!() |
There was a problem hiding this comment.
@drewkett @obi1kenobi I wasn't sure what to do here, thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@obi1kenobi this PR is a rebase (and rework) of @drewkett's earlier PR #945, to add support for custom cargo registries, on top of the latest
main. I say rework asmainhas changed quite a bit since the original PR and so a simple rebase was not enough.This PR also adds an integration test for the custom registry functionality. The test use a static file
mangoregistry which is served via an ephemeralaxusinstance. The test is self contained and does not require any external resources.Finally, an unrelated bug I observed, with the regex used for the
bugreporttest, is resolved. This could be pulled out into a separate PR if needed.The goal here is to get this into a suitable state such that it could be merged to
mainto thus avoid the need to maintain a downstream fork. I have kept my changes separate from @drewkett's original changes to aid in reviewing the delta, but the intention is to eventually squash these.Thanks!