Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when no baseline version found on crates.io #456

Merged
merged 7 commits into from
May 29, 2023
Merged

Improved error message when no baseline version found on crates.io #456

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4059b1
Improves the error message when crate is not found on default registry
era May 28, 2023
79c6d89
Improves the error message when crate is not found on default registry
era May 28, 2023
aa5a244
reverts d4059b1720068610b6b412abae64d0e0ddba339a
era May 28, 2023
53edb30
rust fmt
era May 28, 2023
a54d172
reducing error message and trying to better frame the problem
era May 29, 2023
8cf16a0
Update src/rustdoc_gen.rs
obi1kenobi May 29, 2023
7f423d3
Merge branch 'main' into era/improved_error_message
obi1kenobi May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/rustdoc_gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,10 +658,14 @@ impl RustdocGenerator for RustdocFromRegistry {
rustdoc_cmd: &RustdocCommand,
crate_data: CrateDataForRustdoc,
) -> anyhow::Result<PathBuf> {
let crate_ = self
.index
.crate_(crate_data.name)
.with_context(|| anyhow::format_err!("{} not found in registry", crate_data.name))?;
let crate_ = self.index.crate_(crate_data.name).with_context(|| {
anyhow::format_err!(
"{} not found in registry (crates.io). \
For workarounds check \
obi1kenobi marked this conversation as resolved.
Show resolved Hide resolved
https://github.com/obi1kenobi/cargo-semver-checks#does-the-crate-im-checking-have-to-be-published-on-cratesio",
crate_data.name
)
})?;

let base_version = if let Some(base) = self.version.as_ref() {
base.to_string()
Expand Down