Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint pub_static_now_doc_hidden #712

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

arpity22
Copy link
Contributor

Lint for when a public static is now marked as #[doc(hidden)]

Issue mentioned in #578

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! 🚀

In case you're looking for more lint ideas, here are a couple high-impact ones: #366 (comment)

One of the two not-yet-implemented ones there would have caught an issue that just happened in a PR in the http crate earlier today: hyperium/http#692 (comment)

@obi1kenobi obi1kenobi merged commit c6d3441 into obi1kenobi:main Mar 20, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants