Add xsl to check for negative binding indexes #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon could you check this one, please? |
maxonfjvipon
requested changes
Dec 5, 2023
| <xsl:attribute name="severity"> | ||
| <xsl:text>error</xsl:text> | ||
| </xsl:attribute> | ||
| <xsl:text>Binding index of application must not be a negative number "</xsl:text> |
There was a problem hiding this comment.
@c71n93 I think not only negative but positive with + too
| tests: | ||
| - /program/errors[count(error[@severity='error'])=2] | ||
| eo: | | ||
| object c:-1 d:-2 a:0 b:1 |
There was a problem hiding this comment.
@c71n93 let's add a case with index with +
maxonfjvipon
requested changes
Dec 5, 2023
eo-parser/src/main/resources/org/eolang/parser/errors/negative-binding-indexes.xsl
Outdated
Show resolved
Hide resolved
|
@yegor256 could you check this one, please? |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2670
PR-Codex overview
This PR focuses on adding a new XSL transformation to check if integer bindings in EO applications are negative.
Detailed summary
signed-binding-indexes.xslto check for negative integer bindings in EO applications.ParsingTrain.javato include a TODO comment about checking negative int bindings via XSL.