Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3092): snippet phi -> unphi test #3146

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Apr 25, 2024

Closes: #3092
Closes: #2955
Closes: #2956
Closes: #2957
Closes: #2958
Closes: #2959
Closes: #2960


PR-Codex overview

This PR updates dependencies, removes unused classes, refactors code for clarity, and enhances test coverage in the org.eolang package.

Detailed summary

  • Updated farea version to 0.0.17 in pom.xml
  • Removed unused classes EObytes, EOint, EOstring
  • Refactored Data class for clarity
  • Enhanced SnippetTestCase test coverage with new tests and improved existing tests

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon maxonfjvipon marked this pull request as draft April 26, 2024 08:50
@maxonfjvipon maxonfjvipon marked this pull request as ready for review April 28, 2024 11:42
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented May 2, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 2, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented May 2, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 1min)

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented May 2, 2024

@yegor256 please start merge one more time, there was a conflict after previous merge

@yegor256
Copy link
Member

yegor256 commented May 3, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 3, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a0c917e into objectionary:master May 3, 2024
20 checks passed
@rultor
Copy link
Contributor

rultor commented May 3, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants