Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3163): while logic is fixed #3166

Merged
merged 1 commit into from
May 6, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented May 4, 2024

What's done:

  1. while does not dataize the first step if the first condition is true
  2. while expects condition to have index

Closes: #3163


PR-Codex overview

The focus of this PR is to refactor the while loop logic in the eo-runtime module and add test cases in while-tests.eo.

Detailed summary

  • Refactored while loop logic in eo-runtime
  • Added test cases for while loop in while-tests.eo
  • Improved handling of loop conditions and iterations

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented May 6, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 6, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3821eaf into objectionary:master May 6, 2024
20 checks passed
@rultor
Copy link
Contributor

rultor commented May 6, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 1hr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current logic of while is wrong now
3 participants