Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3696): skip UTs #3710

Merged

Conversation

maxonfjvipon
Copy link
Member

Closes: #3696

@github-actions github-actions bot added the core label Dec 19, 2024
@yegor256
Copy link
Member

@maxonfjvipon there is skipTests parameter in Maven: https://maven.apache.org/plugins-archives/maven-surefire-plugin-2.12.4/examples/skipping-test.html it's not suitable?

@maxonfjvipon
Copy link
Member Author

@yegor256 skipTests skips all tests by maven-surefire-plugin and maven-failsafe-plugin except integration ones by maven-invoker-plugin.

Custom skipITs was skipping integration tests by maven-invoker-plugin, now in EO it also skips tests that end with *IT by maven-failsafe-plugin. So it skips all the integration tests.

I added one more custom skipUTs flag that skips just simple unit tests, but does not touch integration tests by maven-failsafe-plugin and maven-invoker-plugin.

So now we have:

  1. mvn build that runs only unit tests without integration ones
  2. qulice build that runs only qulice without any tests
  3. integration bulid that runs only integration tests by maven-failsafe-plugin and maven-invoker-plugin

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit a2310c3 into objectionary:master Dec 19, 2024
21 checks passed
@yegor256
Copy link
Member

@maxonfjvipon nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failsafe integration tests are too slow
2 participants