feat(#324): Programs.version() #325
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon please check |
| MatcherAssert.assertThat( | ||
| "Version doesn't match with expected", | ||
| new Programs(new ListOf<>()).version(), | ||
| Matchers.equalTo("1.2.3") |
There was a problem hiding this comment.
@h1alexbel is it correct value for testing?
There was a problem hiding this comment.
@maxonfjvipon yes, it comes from src/test/resources/META-INF/MANIFEST.MF:
maxonfjvipon
approved these changes
Feb 11, 2025
|
@yegor256 take a look, please |
yegor256
requested changes
Feb 12, 2025
| * @return Version | ||
| * @checkstyle NonStaticMethodCheck (3 lines) | ||
| */ | ||
| public String version() { |
There was a problem hiding this comment.
@h1alexbel it seems that this method should be static (as checkstyle suggests). However, we don't appreciate static methods. I suggest getting rid of it at all and moving this information into Javadoc. Just explain to the user how he get get the version of the library, via Manifests
|
@h1alexbel thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added
version()method toProgramsto read lints version fromMANIFEST.MF.closes #324