Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relations about measurements of characteristics #655

Closed

Conversation

wdduncan
Copy link
Collaborator

@jamesaoverton
Copy link
Contributor

Can this please be marked as Draft until the OBI group has a chance to discuss it?

@wdduncan wdduncan self-assigned this Nov 22, 2022
@wdduncan wdduncan marked this pull request as draft November 22, 2022 18:58
@wdduncan
Copy link
Collaborator Author

@jamesaoverton it has been converted to a draft

@jamesaoverton
Copy link
Contributor

I'm worried about RO importing from IAO. If 'is about' is needed in RO, can it be moved instead?

For the current use cases, I don't see why anything more than 'is about' is needed, but this PR imports several more IAO terms.

@wdduncan
Copy link
Collaborator Author

@jamesaoverton

I'm worried about RO importing from IAO. If 'is about' is needed in RO, can it be moved instead?

Moving is an option, but IAO would need to agree to it. I submitted an issue getting there opinion.

For the current use cases, I don't see why anything more than 'is about' is needed, but this PR imports several more IAO terms.

Given how broad is about is, I included the child relations to help differentiate the different senses in which an ICE can "be about" something else.

@ddooley
Copy link
Contributor

ddooley commented Dec 13, 2022

I think this can be closed without commit?

@wdduncan
Copy link
Collaborator Author

The issues that generated this PR have been closed. It was determined the relations were not needed.

@wdduncan wdduncan closed this Dec 14, 2022
@wdduncan
Copy link
Collaborator Author

@ddooley Yes ... I've closed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR: is about NTR: is characteristic measurement of NTR 'measurement method of' (previously in AgrO)
3 participants