-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclusiveFacets #1649
Merged
Merged
exclusiveFacets #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1662 tries to solve the array channel reindexing issue we also need to list any other transform or initializer that needs reindexing, and create a test for it |
Merged
mbostock
force-pushed
the
mbostock/exclusive-facets
branch
from
August 18, 2023 20:18
15e303a
to
fc59cae
Compare
Looks good to me. 👍 |
Fil
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! And it works (almost) when merged into #1623, by adding this:
function delaunayMark(DelaunayMark, data, {x, y, ...options} = {}) {
[x, y] = maybeTuple(x, y);
+ options = basic(options, (data, facets) => exclusiveFacets(data, facets));
return new DelaunayMark(data, {...options, x, y});
}
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* exclusiveFacets * pad the data with duplicates * reindex * test * done * reindex iterables * reindex symbol --------- Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1648.
This needs to pad the data with duplicates, too.Done.I think we might also read using non-exclusive faceted index, while writing using the exclusive faceted index. Otherwise channels supplied as arrays of values would not work. I’m not sure whether we would do anything about channels that are supplied as arrays of values that are not read by the transform; that feels like a generic issue where transforms can reindex and break the association with data, and maybe if we consider that an issue, Plot should provide a generic mechanism to reindex channel values after transforming data.Done.