-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for coverage #1825
Merged
Merged
tests for coverage #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes:
- I folded the tests into the parent class or function. For example we already had tests for the line mark’s curve option, so I moved these new tests to be adjacent.
- I changed the test descriptions to match the current pattern (which is mostly
method(...arguments) does something
). - I adopted TypeScript for the tests whenever possible. (We should file an issue for going back and moving all the tests to TypeScript, but we’ll need to use a lot of
as any
to test the undocumented implementation.) - I adopted jsdom.js; the eliminates the need for instantiating JSOM and manually passing the document option to Plot.
mbostock
approved these changes
Aug 23, 2023
mbostock
force-pushed
the
fil/more-tests
branch
from
August 23, 2023 22:56
1062c30
to
fe0de75
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* stack rejects an invalid order * these tests used the default labelAnchor * test curve tension * coverage: valid and invalid curves * move curve tests to a features directory * test channel scales: false, invalid * invalid domain sort options * The aspectRatio option rejects unsupported scale type * test style * test polish * add missing test --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have test:coverage, it becomes easier to add more tests.
From the starting point of (#1818):
Current status:
(It doesn’t look like much, but each addition is worth it!)