Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: LskyPro Upload #4938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woodchen-ink
Copy link
Contributor

@woodchen-ink woodchen-ink commented Dec 20, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin:https://github.com/woodchen-ink/obsidian-lskypro-upload

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

More adaptable to LksyPro's upload strategy than existing plugins
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template
❌ Unable to find a release with the tag 1.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@woodchen-ink woodchen-ink changed the title Submit LskyPro Upload Plugin Add plugin: LskyPro Upload Dec 20, 2024
@woodchen-ink woodchen-ink reopened this Dec 20, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:You should not cast this, instead use a instanceof check to make sure that it's actually the adapter you expect.


Optional

[1]:Use app.fileManager.trashFile(file: TAbstractFile) instead, this will make sure that the file is deleted according to the users preferences.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Dec 21, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Dec 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Jan 7, 2025

Why did you not submit your changes to the original plugin?

# Obsidian LskyPro Upload Plugin
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

Copyright (c) 2023 NekoTarou
Update this.

console.log('Loaded settings:', this.settings);, console.log('Token value:', this.settings.token);, console.log('Authorization header:', authHeader);, console.log('All headers:');
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

{
This is already the default, you can remove this code.

containerEl.createEl("h2", { text: t("Plugin Settings") });
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

new Setting(containerEl)
This button serves no purpose, remove it.

@joethei joethei self-assigned this Jan 7, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 7, 2025
@woodchen-ink
Copy link
Contributor Author

Why did you not submit your changes to the original plugin?

# Obsidian LskyPro Upload Plugin Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

Copyright (c) 2023 NekoTarou Update this.

console.log('Loaded settings:', this.settings);, console.log('Token value:', this.settings.token);, console.log('Authorization header:', authHeader);, console.log('All headers:'); Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

{ This is already the default, you can remove this code.

containerEl.createEl("h2", { text: t("Plugin Settings") }); Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

new Setting(containerEl) This button serves no purpose, remove it.

Because the original plugin has not been updated for a long time, and I have modified key features, deleted some functionalities from the original plugin, the original author is unlikely to merge it.
I have made changes to the points you mentioned.

And the lskypro open-source version has been notified to suspend updates, afterwards I will ensure compatibility with the new 2.0 enterprise version, which will have a different interface than the original plugin.

thanks

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 8, 2025
@joethei
Copy link
Collaborator

joethei commented Jan 15, 2025

Copyright (c) 2025 WoodChen
You need to keep the original copyright here, and add yourself after that.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review Changes made labels Jan 15, 2025
@woodchen-ink
Copy link
Contributor Author

Copyright (c) 2025 WoodChen You need to keep the original copyright here, and add yourself after that.

OK, I have fixed it

Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants