Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Infio Copilot #5083

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

duanfuxiang0
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/infiolab/infio-copilot

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

[1][2][3][4][5][6][7][8][9][10][11][12]:You should not cast this, instead use a instanceof check to make sure that it's actually a file/folder.

[1][2][3][4][5][6][7][8][9][10][11]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems.

[1][2][3][4][5][6][7][8][9][10][11]:You should consider limiting the number of console.logs in your code, to not pollute the dev console.


Optional

[1][2]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 7, 2025
@duanfuxiang0
Copy link
Author

duanfuxiang0 commented Jan 7, 2025

/skip

[1][2][3][4][5][6][7][8][9][10][11]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

These values change dynamically during user interaction and must be calculated in JavaScript to ensure the menu appears in the correct position relative to the text being edited.

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Jan 7, 2025
@duanfuxiang0
Copy link
Author

I have modified everything except for the unchangeable CSS. Could you please review again? I have released version 0.0.3.

@duanfuxiang0
Copy link
Author

duanfuxiang0 commented Jan 7, 2025

ObsidianReviewBot

How should I now reinitiate the review process?

@joethei
Copy link
Collaborator

joethei commented Feb 13, 2025

Sorry for the delay in reviewing.

"description": "A Cursor-inspired AI assistant for Obsidian that offers smart autocomplete and interactive chat with your selected notes",
Don't include "Obsidian" in your plugins description.

this.app.workspace.on("active-leaf-change", (leaf) => {, this.app.metadataCache.on("changed", (file: TFile) => {
Events need to be registered, so they can be properly unloaded when the plugin is disabled. https://docs.obsidian.md/Plugins/Events

id: 'infio-open-new-chat',, id: 'infio-add-selection-to-chat',, id: 'infio-rebuild-vault-index',, id: 'infio-update-vault-index',, id: 'infio-autocomplete-accept',, id: 'infio-autocomplete-predict',, id: "infio-autocomplete-toggle",, id: "infio-autocomplete-disable",, id: "infio-ai-inline-edit",
Don't prefix the command id with parts of the plugin ID, Obsidian will already handle that.

name: 'Infio open new chat',, name: 'Infio add selection to chat',, name: 'Infio rebuild entire vault index',, name: 'Infio update index for modified files',, name: 'Infio Autocomplete Accept',, name: 'Infio Autocomplete Predict',, name: "Infio Autocomplete Toggle",, name: "Infio Autocomplete Disable",, name: "infio Inline Edit",
Same here, remove the Infio string from the text

name: 'Infio Autocomplete Accept',, name: 'Infio Autocomplete Predict',, name: "Infio Autocomplete Toggle",, name: "Infio Autocomplete Disable",, name: "infio Inline Edit",, filePrompt = ## Potentially Relevant Snippets from the current vault](https://github.com/infiolab/infio-copilot/blob/bf29a42baac2d772de6907cd01b0c4c83f4a4a11/src/utils/prompt-generator.ts#L212), [? ## Potentially Relevant Websearch Results, new Setting(containerEl).setHeading().setName('Default Model'), .setName('Model Name'), .setName('API Key'), .setName('Model Name'), .setName('Model Name'), .setName('API Key'), .setName('Model Name'), Add Model, Add Custom Model {isAddModelOpen ? "▼" : "▶"}, Infio Settings v{settings.version}, <h2>Model Options</h2>, name={"Frequency Penalty"}, name={"Presence Penalty"}, name={"Max Tokens"}, name={"Maximum Prefix Length"}, name={"Maximum Suffix Length"}, name={"Factory Reset"}, name={"System Message"}, name={"User Message template"}, name={"Few Shot Examples"}, Human Message, Assistant Message,

LLM Response Information
,
Token Count
, Estimated Price:,
Stop Generation
, {' (Current File)'}
Use sentence case in UI

name="BaseURL (optional):", name="APIKey:", name="IsEmbedding:"
Please add spaces between the words, and make sure to use sentence case.

<h2>Model Options</h2>,
Avoid "options" in settings headings,

Model Options

,
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

dataviews
Please use the proper capitalization of this product name, which is Dataview, and remove the s at the end.

@joethei joethei added Minor changes requested PR can be merged after some final changes have been requested and removed Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Feb 13, 2025
@joethei joethei assigned joethei and unassigned ObsidianReviewBot Feb 13, 2025
@duanfuxiang0
Copy link
Author

duanfuxiang0 commented Feb 18, 2025

I have released version 0.04, which addresses the aforementioned issues. Could you please review it again? Thank you very much.

https://github.com/infiolab/infio-copilot/releases/tag/0.0.4

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: robertttbs/obsidian-enhanced-canvas. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

In case of conflict, move my description to the end of the list.
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."lot"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants