Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Rsync #5258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GanapathyRaman
Copy link

@GanapathyRaman GanapathyRaman commented Jan 29, 2025

Plugin name: Rsync

Author: Ganapathy Raman

Description: Sync notes and automate backups using Rsync.

Repo link: Rsync GitHub Repository

Version: 1.0.0

License: MIT License


  • I have tested the plugin on:
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz):
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v).
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at Obsidian Developer Policies, and have assessed my plugin's adherence to these policies.
  • I have read the tips in Obsidian Plugin Guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
  • I have given proper attribution to these other projects in my README.md.

Added a new Rsync plugin

Community Plugin
Plugin: Rsync Plugin
Author: Ganapathy Raman
Description: A plugin to sync notes and automates backups using Rsync .
Repository: GanapathyRaman/rsync-plugin
Version: 1.0.0
License: MIT License
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ You did not follow the pull request template


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Added Rsync plugin to the community-plugins.json Add plugin: Rsync Jan 29, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

[1][2][3]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 30, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 30, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants